Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDefine ck() based on cfg(debug_assertions) #182
Merged
+15
−4
Conversation
|
I dug into GL error handling a bit more and found out that there are only a handful of standard GL errors so I made the panic message a bit more helpful in 7563e95. |
|
Yikes, good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
toolness commentedJun 5, 2019
While attempting to investigate #178, I noticed that the
ck()function, which checks to see if there's a GL error and panics if so, wasn't running on my debug build. Its definition was conditional based on whethercfg(debug)is set, but I'm not actually sure what that is or how to set it, whereascfg(debug_assertions)does the trick.This PR changes the conditional compilation to be based on
debug_assertions. However, if that's not the right way to approach this, please let me know!