Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfixes and a possible canvas addition #218
Merged
+53
−7
Conversation
|
|
| @@ -94,12 +94,12 @@ impl Shape { | |||
|
|
|||
| #[inline] | |||
| fn first(&self) -> LineSegment { | |||
| self.outline.first().unwrap() | |||
| *self.outline.first().unwrap() | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
s3bk
Jul 22, 2019
Author
Contributor
without:
error[E0308]: mismatched types
--> swf/src/shapes.rs:102:9
|
101 | fn last(&self) -> LineSegment {
| ----------- expected `shapes::LineSegment` because of return type
102 | self.outline.last().unwrap()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| expected struct `shapes::LineSegment`, found reference
| help: consider dereferencing the borrow: `*self.outline.last().unwrap()`
|
= note: expected type `shapes::LineSegment`
found type `&shapes::LineSegment`
|
Hmm, we shouldn't return a reference from |
not much that can be done here … |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
s3bk commentedJul 16, 2019
•
edited
What I am not sure about is
fill_layout(see #202). I added it because it was needed to push layouts directly, but currently I am working on removing the dependency on text altogether. (And instead push the glyph outlines).