Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text rendering optional in pathfinder_canvas #225

Merged
merged 3 commits into from Aug 5, 2019

Conversation

@est31
Copy link
Contributor

est31 commented Jul 27, 2019

Fixes #164
Fixes #208

@est31 est31 force-pushed the est31:optional_text_rendering branch from 5bff934 to fa1a32b Jul 27, 2019
@est31
Copy link
Contributor Author

est31 commented Jul 27, 2019

cc @s3bk this is what you wanted I think

@est31
Copy link
Contributor Author

est31 commented Jul 27, 2019

I've tested @s3bk 's pdf viewer with this patch and it works great.

@s3bk
Copy link
Contributor

s3bk commented Jul 27, 2019

thanks!
Do you think it would be cleaner to move the text stuff into canvas/src/text.rs ?

@est31
Copy link
Contributor Author

est31 commented Jul 27, 2019

@s3bk yeah it's cleaner. I've pushed a commit to move the text stuff into separate files.

@pcwalton
Copy link
Collaborator

pcwalton commented Aug 5, 2019

I generally prefix all Pathfinder features with pf- to avoid conflicts with other crates.

@est31 est31 force-pushed the est31:optional_text_rendering branch from c1cd96c to f5080da Aug 5, 2019
@est31 est31 force-pushed the est31:optional_text_rendering branch from f5080da to 3928e8d Aug 5, 2019
@est31
Copy link
Contributor Author

est31 commented Aug 5, 2019

re-r? @pcwalton

@pcwalton pcwalton merged commit f89ed90 into servo:master Aug 5, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Travis CI - Pull Request Build Passed
Details
@pcwalton
Copy link
Collaborator

pcwalton commented Aug 5, 2019

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.