Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake text rendering optional in pathfinder_canvas #225
+232
−177
Conversation
|
cc @s3bk this is what you wanted I think |
|
I've tested @s3bk 's pdf viewer with this patch and it works great. |
|
thanks! |
|
@s3bk yeah it's cleaner. I've pushed a commit to move the text stuff into separate files. |
|
I generally prefix all Pathfinder features with |
|
re-r? @pcwalton |
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
est31 commentedJul 27, 2019
•
edited
Fixes #164
Fixes #208