Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBump lyon, font-kit and skribo versions to fix crashes #242
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SethDusek commentedNov 20, 2019
•
edited
Hi. This bumps font-kit, lyon, and skribo versions to fix a crash in the canvas_text program which was a result of a bug in font-kit which seemed to have been fixed in this commit, yet since pathfinder and its dependencies were using an older version of font-kit, it did not receive this fix. As a result, canvas_text would crash with the following:
This patch bumps font-kit versions in pathfinder's dependencies and fixes the breaking changes that come with it. I've also submitted a PR to skribo for it to use font-kit 0.4, and that has been merged.
edit: I should probably mention this fixes #231