Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lyon, font-kit and skribo versions to fix crashes #242

Merged
merged 1 commit into from Nov 30, 2019

Conversation

@SethDusek
Copy link
Contributor

SethDusek commented Nov 20, 2019

Hi. This bumps font-kit, lyon, and skribo versions to fix a crash in the canvas_text program which was a result of a bug in font-kit which seemed to have been fixed in this commit, yet since pathfinder and its dependencies were using an older version of font-kit, it did not receive this fix. As a result, canvas_text would crash with the following:

thread 'main' panicked at 'assertion failed: *current_point_index <= last_point_index_in_contour', /home/kamal/.cargo/registry/src/github.com-1ecc6299db9ec823/font-kit-0.2.0/src/loaders/freetype.rs:576:13

This patch bumps font-kit versions in pathfinder's dependencies and fixes the breaking changes that come with it. I've also submitted a PR to skribo for it to use font-kit 0.4, and that has been merged.

edit: I should probably mention this fixes #231

@pcwalton pcwalton merged commit b912cbb into servo:master Nov 30, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.