Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove log restriction #254
Merged
Conversation
pathfinder-geometry enabled a log feature that restricts logging to warn for any binary using it.
|
This is actually enabled in a few more places. A Thanks for finding it! I already replaced the log crate because I could not find why log didn't work. |
|
yes i've removed all places where it appears now |
|
I actually don't know why this got in there. Maybe it was added in a PR? Anyway, thanks for finding it! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
arturoc commentedJan 28, 2020
pathfinder-geometry enabled a log feature that restricts logging to warn for any binary using it.
This is really hard to find for anyone using the package as suddenly logging seems to stop working for no apparent reason