Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBump almost all dependencies to their latest version #257
+870
−936
Conversation
|
Now that #259 has been merged, tests should pass and this should be good to go! |
linkmauve
added a commit
to linkmauve/pathfinder
that referenced
this pull request
Jun 5, 2020
bors-servo
added a commit
that referenced
this pull request
Jun 16, 2020
Only use foreign-types on macOS in the C API Its only use is for `CoreAnimationLayerRef::from_ptr()` in `PFMetalDeviceCreate`, so this fixes a warning on other platforms. The last time I tried to fix this warning I didn’t notice that it was actually used, and thus 2d2bc14 broke the macOS build in #257.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
linkmauve commentedFeb 4, 2020
•
edited
I’m pleasantly surprised so few of them required any kind of (visible) code change. The few which did have a dedicated commit.
The only remaining one according to
cargo-outdatedispathfinder_text’s dependency onlyon_path, but this is just waiting for afont-kitrelease as that crate dropped lyon from its direct dependencies anyway.A
cargo testgoes down from 373 crates to 365 crates to build.