Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRe-export necessary items in pathfinder-canvas #293
Merged
+11
−7
Conversation
Export types need to use the canvas API from other pathfinder crates. From pathfinder-color all types and convinience functions are exported. From pathfinder-geometry only the 2D vector and rect types with their convinience functions are exported. Items from pathfinder-renderer are not re-exported as they also belong to the back-end. Pattern, while used in the canvas API, is not re-exported as it is not needed for basic usage and depends on a lot of other types. See #283
|
Not sure why continuous-integration/travis-ci/pr is still pending. If I click on details it shows a successful run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pyfisch commentedApr 4, 2020
Export types need to use the canvas API from other pathfinder crates.
From pathfinder-color all types and convinience functions are exported.
From pathfinder-geometry only the 2D vector and rect types with
their convinience functions are exported.
Items from pathfinder-renderer are not re-exported as they also
belong to the back-end.
Pattern, while used in the canvas API, is not re-exported as
it is not needed for basic usage and depends on a lot of other types.
See #283