Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace cbindgen with cargo-c #343
Closed
+28
−25
Conversation
cargo-c was written for rav1e’s usecase of generating and installing a C ABI the proper way, with a static library, a shared library, a pkg-config file, and the include files at the right location, and pathfinder has the exact same needs. This requires the user to use a different command from the usual `cargo build`, which is why I added a README.md. Ideally we’d add a path prefix for the include directory, to allow multiple versions to be installed at the same time until we freeze the API, but cargo-c doesn’t support it yet.
|
This patch is now used to build the pathfinder-git package in AUR, I’ll remove it from there once it is merged. |
|
This looks OK overall, except renaming the crate name. I filed lu-zero/cargo-c#83. |
pcwalton
added a commit
to pcwalton/pathfinder
that referenced
this pull request
Jun 24, 2020
bors-servo
added a commit
that referenced
this pull request
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
linkmauve commentedMay 18, 2020
cargo-c was written for rav1e’s usecase of generating and installing a C ABI the proper way, with a static library, a shared library, a pkg-config file, and the include files at the right location, and pathfinder has the exact same needs.
This requires the user to use a different command from the usual
cargo build, which is why I added a README.md.Ideally we’d add a path prefix for the include directory, to allow multiple versions to be installed at the same time until we freeze the API, but cargo-c doesn’t support it yet.