Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use foreign-types on macOS in the C API #353

Merged
merged 1 commit into from Jun 16, 2020

Conversation

@linkmauve
Copy link
Contributor

linkmauve commented Jun 5, 2020

Its only use is for CoreAnimationLayerRef::from_ptr() in PFMetalDeviceCreate, so this fixes a warning on other platforms.

The last time I tried to fix this warning I didn’t notice that it was actually used, and thus 2d2bc14 broke the macOS build in #257.

Its only use is for CoreAnimationLayerRef::from_ptr() in
PFMetalDeviceCreate, so this fixes a warning on other platforms.

The last time I tried to fix this warning I didn’t notice that it was
actually used, and thus 2d2bc14 broke
the macOS build in #257.
@pcwalton
Copy link
Collaborator

pcwalton commented Jun 16, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2020

📌 Commit f2c0aba has been approved by pcwalton

@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2020

Testing commit f2c0aba with merge 22d5dbc...

@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2020

☀️ Test successful - checks-travis
Approved by: pcwalton
Pushing 22d5dbc to master...

@bors-servo bors-servo merged commit 22d5dbc into servo:master Jun 16, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@linkmauve linkmauve deleted the linkmauve:no-foreign-types branch Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.