Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExpose EmbeddedResourceLoader to c api #377
Merged
Conversation
|
@bors-servo: r+ |
|
|
|
Looks great, thanks! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
NickSpag commentedJun 29, 2020
•
edited
Background
This PR exposes the c api to the EmbeddedResourceLoader, to prevent some of the issues mentioned here.
Approach
PFFilesystemResourceLoaderLocateand simply exposed the ERL's new and boxed it in the ResourceLoaderWrapperCreateterminology in the signature to match the rest of the api where a new() is calledNotes
Let me know if I misinterpreted anything or if there are any changes, stylistic or otherwise, that you'd prefer. Thanks!