Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose EmbeddedResourceLoader to c api #377

Conversation

@NickSpag
Copy link
Contributor

NickSpag commented Jun 29, 2020

Background

This PR exposes the c api to the EmbeddedResourceLoader, to prevent some of the issues mentioned here.

Approach

  • Followed PFFilesystemResourceLoaderLocate and simply exposed the ERL's new and boxed it in the ResourceLoaderWrapper
  • Used the Create terminology in the signature to match the rest of the api where a new() is called

Notes

  • I successfully tested it in a little .NET binding project I'm working on.
  • Moved the `gl` section comment down with the GL methods, as it seemed a little out of place. added a `resources` one. then moved the destroy fn in to the new section.

Let me know if I misinterpreted anything or if there are any changes, stylistic or otherwise, that you'd prefer. Thanks!

NickSpag added 3 commits Jun 29, 2020
@NickSpag NickSpag changed the title Feature/expose embeddedresourceloader to c api Expose EmbeddedResourceLoader to c api Jun 29, 2020
@pcwalton
Copy link
Collaborator

pcwalton commented Jun 29, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2020

📌 Commit 04787f1 has been approved by pcwalton

@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2020

Testing commit 04787f1 with merge a51176a...

@pcwalton
Copy link
Collaborator

pcwalton commented Jun 29, 2020

Looks great, thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2020

☀️ Test successful - checks-travis
Approved by: pcwalton
Pushing a51176a to master...

@bors-servo bors-servo merged commit a51176a into servo:master Jun 29, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@NickSpag NickSpag deleted the NickSpag:feature/expose-embeddedresourceloader-to-c-api branch Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.