Skip to content

/ pathfinder

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Metal memory management and the `canvas_metal_minimal`, `canvas_nanovg`, and `macos_app` examples. #378

Merged
merged 1 commit into from Jun 29, 2020
Merged

Fix Metal memory management and the `canvas_metal_minimal`, `canvas_nanovg`, and `macos_app` examples. #378

merged 1 commit into from Jun 29, 2020

Conversation

@pcwalton
Copy link
Collaborator

pcwalton commented Jun 29, 2020

winit does not create an autorelease pool, so the Metal backend had not taken
the presence of one into account. Now the Metal backend creates and flushes
autorelease pools as necessary.

Closes #334.
Closes #376.
@pcwalton
Fix Metal memory management and the `canvas_metal_minimal`, `canvas_n…
Loading status checks…
42289ee 
…anovg`,

and `macos_app` examples.

`winit` does not create an autorelease pool, so the Metal backend had not taken
the presence of one into account. Now the Metal backend creates and flushes
autorelease pools as necessary.

Closes #334.
Closes #376.
@pcwalton
Copy link
Collaborator Author

pcwalton commented Jun 29, 2020

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2020

📌 Commit 42289ee has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2020

⌛ Testing commit 42289ee with merge c6e7ed0...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2020

☀️ Test successful - checks-travis
Approved by: pcwalton
Pushing c6e7ed0 to master...
@bors-servo bors-servo merged commit c6e7ed0 into servo:master Jun 29, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@pcwalton pcwalton deleted the pcwalton:macos-fixes branch Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Error building `canvas_nanovg` example
macos_app does not work
2 participants
@pcwalton @bors-servo
You can’t perform that action at this time.