Skip to content

/ pathfinder

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround to fix compiler issue in TS 2.4 #38

Closed
wants to merge 1 commit into from
Closed

Workaround to fix compiler issue in TS 2.4 #38

wants to merge 1 commit into from

Conversation

@mbebenita
Copy link
Contributor

mbebenita commented Oct 25, 2017

See: microsoft/TypeScript#16509

ERROR in ./src/svg-demo.ts
(195,61): error TS2345: Argument of type 'Partial<Timings>' is not assignable to parameter of type 'Timings'.
  Types of property 'compositing' are incompatible.
    Type 'number | undefined' is not assignable to type 'number'.
      Type 'undefined' is not assignable to type 'number'.
@mbebenita
Workaround to fix compiler issue in TS.2.4, see microsoft/TypeScript#…
b98ddf5 
…16509
@mbebenita mbebenita mentioned this pull request Oct 25, 2017
Merged
@pcwalton
Copy link
Collaborator

pcwalton commented Oct 25, 2017

I incorporated a fix for this as part of the most recent DirectWrite changes. Thanks for the PR though :)
@pcwalton pcwalton closed this Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@mbebenita @pcwalton
You can’t perform that action at this time.