Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake `canvas_minimal` example rerender on refresh #404
+42
−34
Conversation
|
This breaks on macOS because |
|
Hmm, I can't find anything that looks like a "window shown" event. I think I'll move the rendering code again, and then use boolean to indicate that the screen needs to be redrawn. |
|
@bors-servo: r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
leroycep commentedJul 17, 2020
I'm not sure if this actually works, because the
canvas_minimalexample doesn't run on my computer.