Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [defines] section to cbindgen.toml #424

Merged
merged 2 commits into from Jul 29, 2020
Merged

Conversation

@BenGachowski
Copy link
Contributor

BenGachowski commented Jul 29, 2020

Attempts to fix issue #422.

@pcwalton
Copy link
Collaborator

pcwalton commented Jul 29, 2020

Can we just write "target_os = macos" = "__APPLE__"?

@BenGachowski
Copy link
Contributor Author

BenGachowski commented Jul 29, 2020

I don't see why not, that should work just fine.

@pcwalton
Copy link
Collaborator

pcwalton commented Jul 29, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2020

📌 Commit 56b432b has been approved by pcwalton

@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2020

Testing commit 56b432b with merge a0d5b57...

bors-servo added a commit that referenced this pull request Jul 29, 2020
Add [defines] section to cbindgen.toml

Attempts to fix [issue #422](#422).
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2020

💔 Test failed - checks-travis

@pcwalton pcwalton merged commit c6151da into servo:master Jul 29, 2020
2 of 3 checks passed
2 of 3 checks passed
homu Test failed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.