Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRun demo on new typescript #47
Closed
+5
−2
Conversation
|
This is microsoft/TypeScript#19656 whose fix isn't in a release yet. If you switch typescript's version to |
|
Oh, fantastic! |
whmountains
commented
Nov 9, 2017
|
Don't close, we need the fix. |
|
Really? Presumably the TS changes will release soon? |
|
I'm confused :) |
|
from irc if anyone's following along here:
|
|
2578298 includes this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
anp commentedNov 9, 2017
Not a particularly useful PR, but when attempting to run the demo locally the semver bound in package.json allows TypeScript 2.6.1 to be installed, which seems to break the client demo build:
I also added yarn.lock to gitignore since the README recommends npm, but would be happy to revert.
I suspect that resolving the TS errors with more accurate type defs might be more reasonable, but this allowed me to run the demo on a fresh clone.