Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes #51 by introducing a variable for an early return boolean. #55
+5
−5
Conversation
This works around a bug in the macOS Nvidia shader compiler in 2014 rMBPs.
leeoniya
commented
Dec 6, 2017
|
this looks like a new one. might be worth adding to https://github.com/servo/webrender/wiki/Driver-issues |
|
@leeoniya Done! |
|
UGH. Thanks for tracking this down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
trishume commentedDec 6, 2017
•
edited
See #51. This works around a bug in the macOS Nvidia shader compiler in 2014 rMBPs. The fix shows that as suspected this is very clearly a GPU bug. The funny part is that the compiler is clearly not great since putting the condition in a variable that isn't used anywhere shouldn't make much difference to a competent compiler.
I hope putting the condition in a variable doesn't significantly regress performance on other platforms. Might be worth a benchmark.
I also removed the unused
lineDoesNotPassThroughPixelfunction.cc @pcwalton @mmastrac