Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse servo-freetype instead of the system-native freetype #78
Conversation
|
@Brooooooklyn I know, but I don't think that webrender will switch to a dynamically-linked approach. So I'd rather have freetype statically linked. I mean, servo already links against servo-freetype, so there isn't any benefit in dynamically linking freetype (from servos perspective). On the upside, nobody will have build issues anymore because their version of freetype is somehow wrong. |
|
Just did this myself. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fschutt commentedApr 5, 2018
See servo/webrender#2617
It seems that
freetype-sys, which is what pathfinder uses, links to the system-native freetype version, i.e. whatever you happen to have installed right now. webrender, on the other hand, usesfreetype, which is theservo-freetypeversion, which embeds a full copy of freetype into the binary. This also means that pathfinder shouldn't build on linux if you don't have freetype installed.I had to rename a few things, because a feature, a module and a crate that are all named "freetype" led to naming conflicts.