Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use servo-freetype instead of the system-native freetype #78

Closed
wants to merge 1 commit into from

Conversation

@fschutt
Copy link
Contributor

fschutt commented Apr 5, 2018

See servo/webrender#2617

It seems that freetype-sys, which is what pathfinder uses, links to the system-native freetype version, i.e. whatever you happen to have installed right now. webrender, on the other hand, uses freetype, which is the servo-freetype version, which embeds a full copy of freetype into the binary. This also means that pathfinder shouldn't build on linux if you don't have freetype installed.

I had to rename a few things, because a feature, a module and a crate that are all named "freetype" led to naming conflicts.

@fschutt
Copy link
Contributor Author

fschutt commented Apr 5, 2018

@Brooooooklyn I know, but I don't think that webrender will switch to a dynamically-linked approach. So I'd rather have freetype statically linked. I mean, servo already links against servo-freetype, so there isn't any benefit in dynamically linking freetype (from servos perspective). On the upside, nobody will have build issues anymore because their version of freetype is somehow wrong.

@pcwalton
Copy link
Collaborator

pcwalton commented Apr 10, 2018

Just did this myself. Thanks!

@pcwalton pcwalton closed this Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.