Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix the API of glyph_dimensions to make webrender compile on Windows #81
Conversation
added 2 commits
Apr 13, 2018
|
The Windows This fixes another error of servo/webrender#2645. |
|
@pcwalton I made the API more or less like the Mac version, I hope it's ok to do this. |
|
Merged, sorry for the delay! Thanks! |
bors-servo
referenced
this pull request
in servo/webrender
May 1, 2018
Fix From conversion from NativeFontHandleWrapper to PathfinderComPtr See https://github.com/pcwalton/pathfinder/pull/81 and #2645 - this fixes 1 compile error, where we can't convert from a NativeFontHandleWrapper to a ComPtr. We need this, so that PathfinderFontContext::add_native_font() works correctly. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2705) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fschutt commentedApr 13, 2018
•
edited
See servo/webrender#2645 - this fixes 2 of the 6 errors I get when compiling webrender on Windows.
I decided to use the same API that is used for Mac & Linux builds, with the extra
exactparameter and returning an Error instead of an Option. Maybe it would be a good idea to change it back toOptioninstead ofErr<()>, but then please change it in all 3 APIs.