Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow euclid 0.13 #2
Merged
Conversation
Cargo.toml
Outdated
| @@ -10,6 +10,6 @@ documentation = "https://docs.rs/plane-split" | |||
|
|
|||
| [dependencies] | |||
| binary-space-partition = "0.1.2" | |||
| euclid = "0.11.2" | |||
| euclid = ">= 0.11, < 0.14" | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Eijebong
May 29, 2017
Author
Member
Because I didn't want it to be a breaking change. Since I need to bump the version to 0.4.0 anyway, i'll bump euclid to 0.13
Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "plane-split" | |||
| version = "0.3.0" | |||
| version = "0.3.1" | |||
This comment has been minimized.
This comment has been minimized.
kvark
May 29, 2017
Member
Given the euclid types are exposed in the public API, this needs to have a minor bump to 0.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Eijebong commentedMay 28, 2017
No description provided.