New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect the case of the opposite normals, with extra tests #24

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
2 participants
@kvark
Member

kvark commented Oct 23, 2018

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1454706
TODO: actually build Gecko with it and make a try push
@nical - this should be ready for review anyway

@kvark kvark requested a review from nical Oct 23, 2018

@nical

nical approved these changes Oct 23, 2018

@kvark

This comment has been minimized.

Member

kvark commented Oct 23, 2018

Confirmed it works with a local FF build that has plane-split dependency overridden to this version.
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2117b82536070c8d1bbac5a0d5f76180bddf2588

@kvark

This comment has been minimized.

Member

kvark commented Oct 24, 2018

Oops, the try didn't include sources for this crate, here is a fixed one 🤞 :
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bde8541d2f34085689374b08b607e914dd4288b1

@kvark

This comment has been minimized.

Member

kvark commented Oct 24, 2018

Try looks good, merging. @nical thanks for the quick review!

@kvark kvark merged commit c7be860 into servo:master Oct 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kvark kvark deleted the kvark:opposite branch Oct 24, 2018

bors-servo added a commit to servo/webrender that referenced this pull request Oct 24, 2018

Auto merge of #3227 - kvark:plane-update, r=gw3583
Plane split dependency update

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1454706
Includes servo/plane-split#24
Try push - https://treeherder.mozilla.org/#/jobs?repo=try&revision=bde8541d2f34085689374b08b607e914dd4288b1
r? anyone

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3227)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment