This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for linear gradients #102
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
metajack
commented on src/azure_hl.rs in 926e377
Oct 16, 2014
|
Why the name mismatch between ColorPattern and Pattern? |
This comment has been minimized.
This comment has been minimized.
|
It models the subclassing. Pattern is the superclass of ColorPattern and LinearGradientPattern. In Azure |
This comment has been minimized.
This comment has been minimized.
metajack
commented on 926e377
Oct 16, 2014
|
r=me except for the questions I had. |
pcwalton
added a commit
that referenced
this pull request
Oct 16, 2014
Add support for linear gradients
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedOct 16, 2014
r? @metajack