This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uplibazure: Enable subpixel text in Skia. #103
Merged
Conversation
Drastically improves text rendering in Servo, especially on non-Retina displays.
This comment has been minimized.
This comment has been minimized.
metajack
commented on b421f84
Oct 20, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
metajack
replied
Oct 20, 2014
|
does upstream do this too now? |
This comment has been minimized.
This comment has been minimized.
|
@metajack Doesn't look like it: http://mxr.mozilla.org/mozilla-central/search?string=setSubpixel |
This comment has been minimized.
This comment has been minimized.
metajack
replied
Oct 21, 2014
|
@pcwalton I guess my next question is why not? I guess because they aren't using the Skia backend much? |
This comment has been minimized.
This comment has been minimized.
|
Either that, or they aren't using Azure yet. I'm not sure. |
metajack
added a commit
that referenced
this pull request
Oct 20, 2014
libazure: Enable subpixel text in Skia.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedOct 20, 2014
Drastically improves text rendering in Servo, especially on non-Retina
displays.
r? @metajack