This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for creating similar draw targets and querying the current format and transform #112
Conversation
format and transform
|
Looks good to me, except for the different kinds of C++ cast that I’d like someone else to have a look at. |
tbu-
commented
Nov 26, 2014
|
@SimonSapin |
|
@tbu-, do their usage in this PR look good to you? |
tbu-
commented
Nov 26, 2014
|
They look right, but unfortunately I don't know the interna of these types so I can't tell for sure. (I don't know whether the function that is passed the |
This comment has been minimized.
This comment has been minimized.
metajack
commented on b92d24a
Nov 26, 2014
|
r+ |
metajack
added a commit
that referenced
this pull request
Nov 26, 2014
Add support for creating similar draw targets and querying the current format and transform
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Dec 3, 2014
This adds the infrastructure necessary to support stacking contexts that are not containing blocks for absolutely-positioned elements. Our infrastructure did not support that before. This minor revamp actually ended up simplifying the logic around display list building and stacking-relative position computation for absolutely-positioned flows, which was nice. This will need this PR: servo/rust-azure#112 I have not updated the Cargo.lock file yet because I want the merge commit. r? @glennw f? @SimonSapin
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 30, 2019
…(from pcwalton:opacity); r=SimonSapin This adds the infrastructure necessary to support stacking contexts that are not containing blocks for absolutely-positioned elements. Our infrastructure did not support that before. This minor revamp actually ended up simplifying the logic around display list building and stacking-relative position computation for absolutely-positioned flows, which was nice. This will need this PR: servo/rust-azure#112 I have not updated the Cargo.lock file yet because I want the merge commit. r? glennw f? SimonSapin Source-Repo: https://github.com/servo/servo Source-Revision: 68c90e27970808bddcb8c8a4e782bd4405e67a5c UltraBlame original commit: 9fd9309fcce40850db268814c7cd8886ae472dfc
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…(from pcwalton:opacity); r=SimonSapin This adds the infrastructure necessary to support stacking contexts that are not containing blocks for absolutely-positioned elements. Our infrastructure did not support that before. This minor revamp actually ended up simplifying the logic around display list building and stacking-relative position computation for absolutely-positioned flows, which was nice. This will need this PR: servo/rust-azure#112 I have not updated the Cargo.lock file yet because I want the merge commit. r? glennw f? SimonSapin Source-Repo: https://github.com/servo/servo Source-Revision: 68c90e27970808bddcb8c8a4e782bd4405e67a5c UltraBlame original commit: 9fd9309fcce40850db268814c7cd8886ae472dfc
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…(from pcwalton:opacity); r=SimonSapin This adds the infrastructure necessary to support stacking contexts that are not containing blocks for absolutely-positioned elements. Our infrastructure did not support that before. This minor revamp actually ended up simplifying the logic around display list building and stacking-relative position computation for absolutely-positioned flows, which was nice. This will need this PR: servo/rust-azure#112 I have not updated the Cargo.lock file yet because I want the merge commit. r? glennw f? SimonSapin Source-Repo: https://github.com/servo/servo Source-Revision: 68c90e27970808bddcb8c8a4e782bd4405e67a5c UltraBlame original commit: 9fd9309fcce40850db268814c7cd8886ae472dfc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedNov 8, 2014
More stuff needed for
box-shadow.r? @metajack