This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement a `FillWithBlur` method for `box-shadow` #115
Conversation
|
Should this go upstream? |
|
Yes. |
modeled on the way Chromium does it.
|
r? @SimonSapin/@metajack This is a revised version that does box shadows more or less exactly how Chromium does. |
|
Closing because the filter pipeline stuff in upstream, more recent Azure will probably obviate the need for this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedNov 17, 2014
This seems to allow us to achieve the correct behavior cleanly. I've only implemented this in the Skia backend for now, where it ought to be GPU accelerated if Skia supports that (via
SkShader).r? @SimonSapin