This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate for namespaced enums. #116
Merged
Conversation
| BackendType::CoreGraphicsAcceleratedBackend => 3, | ||
| BackendType::CairoBackend => 4, | ||
| BackendType::SkiaBackend => 5, | ||
| BackendType::RecordingBackend => 6, |
This comment has been minimized.
This comment has been minimized.
SimonSapin
Nov 28, 2014
Member
Should we take the opportunity to make variant names shorter? E.g. remove the Backend suffixes here.
This comment has been minimized.
This comment has been minimized.
Ms2ger
Nov 28, 2014
Author
Contributor
I tend to be more conservative about changes made along with rustups; they are usually big enough on their own.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedNov 28, 2014
No description provided.