This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport cubic Bezier curves #130
Closed
Conversation
| @@ -1020,6 +1041,22 @@ impl<'a> PatternRef<'a> { | |||
| } | |||
| } | |||
|
|
|||
| pub enum Pattern { | |||
This comment has been minimized.
This comment has been minimized.
|
The change looks good to me though I slightly prefer "controlPoint" and "aControlPoint" spelled out instead of the "cp" abbreviation. Servo doesn't have a strong policy on that, as far as I know, so my suggestion does not block the PR in any way. |
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 30, 2015
r? @jdm Depends on servo/euclid#65 and servo/rust-azure#130
This comment has been minimized.
This comment has been minimized.
mrobinson
commented on src/azure_hl.rs in 99792b5
Jan 30, 2015
|
This should be fixed in master. |
This comment has been minimized.
This comment has been minimized.
mrobinson
commented on src/azure_hl.rs in 99792b5
Jan 30, 2015
|
Love the proper use of the diacritical! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedJan 13, 2015
r? @glennw (or whoever)