This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnhance the detection of SSE2-compatible targets #132
Merged
+7
−1
Conversation
|
I wonder if it would make sense to simply enumerate the SSE targets? |
|
You mean like ? |
|
It might be more fool-proof. |
Assuming that any target that doesn't have "arm" in its name is an i686 or x86_64 and thus SSE2-compatible is incorrect (counter examples: aarch64 or mips). Make the check as fool-proof as possible.
|
Does the updated patch look better? |
|
Yeah, let's give this a try. Thanks! |
mrobinson
added a commit
that referenced
this pull request
Jan 18, 2015
Enhance the detection of SSE2-compatible targets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
akosthekiss commentedJan 14, 2015
Assuming that any target that doesn't have "arm" in its name is i686 or x86_64
and thus SSE2-compatible is incorrect (counter example: aarch64). It's better to
look for "86", which appears in the name of all 8086 descendants.