This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSeparate out Skia interfaces and abstract away DrawTarget backing #133
+109
−199
Conversation
|
I'd like to leave this until after the Rust upgrade, if possible. |
|
Sure, makes a lot of sense. |
|
Looks good to me, can merge once the minor issues are sorted in the corresponding skia PR. |
This allows using Skia independently of Azure.
Instead of reaching into the private Skia API to create Skia draw targets, use the Azure API and the newly exposed Skia rust API. This is part of the transition of teasing out the Skia-specific parts of rust-azure.
This will make it easier to generically consume DrawTargets. If DrawTarget ever has support for other surface types, it will be much easier to generate shared surfaces from them. This allows hiding the GL Skia implementation detail behind another layer of abstraction.
mrobinson
force-pushed the
mrobinson:skia-draw-target-cleanup
branch
from
40e521f
to
f9864ef
mrobinson
added a commit
that referenced
this pull request
Jan 29, 2015
Separate out Skia interfaces and abstract away DrawTarget backing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedJan 20, 2015
This will make it possible to move shared surface allocation to the Compositor and to use different types of Azure backends.