This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplementing equality operator for AzColor and Color objects. #140
Conversation
src/azure.rs
Outdated
| #[inline] | ||
| impl PartialEq for AzColor { | ||
| fn eq(&self, other: &AzColor) -> bool { | ||
| if self.r != other.r || self.g != other.g || self.b != other.b || self.a != other.a { |
This comment has been minimized.
This comment has been minimized.
mrobinson
Jan 30, 2015
Member
Why not just do:
self.r == other.r && self.g == other.g...
and skip the conditional block?
This comment has been minimized.
This comment has been minimized.
Adenilson
Jan 30, 2015
Author
Contributor
Yeah, it makes sense and the code will be cleaner. Let me update it.
| @@ -125,6 +125,16 @@ impl Color { | |||
| } | |||
| } | |||
|
|
|||
| #[inline] | |||
| impl PartialEq for Color { | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Looks good to me! |
mrobinson
added a commit
that referenced
this pull request
Jan 30, 2015
Implementing equality operator for AzColor and Color objects.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Adenilson commentedJan 30, 2015
This should easy the use of AzColor by servo (e.g. layout_task.rs).