Remove the other Color type. The idea is to use AzColor for everything.

[Adenilson]

No description provided.

[mrobinson]

I really don't think we should have a method called "hack."

[Adenilson]

Yep, I agree. How you like to have it named?

[mrobinson]

Why is it necessary? It's unclear why you need to create a new AzColor where it's used.

[Adenilson]

Legacy code calls converting the Color to AzColor and vice-versa. I will
try to remove them.

On Mon, Feb 9, 2015 at 12:38 PM, Martin Robinson notifications@github.com
wrote:

In src/azure.rs
#141 (comment):

@@ -261,6 +261,16 @@ impl PartialEq for AzColor {
}
}

+impl AzColor {

• pub fn new(r: AzFloat, g: AzFloat, b: AzFloat, a: AzFloat) -> AzColor {

•     AzColor { r: r, g: g, b: b, a: a }
  

• }

• pub fn hack(color: AzColor) -> AzColor {

Why is it necessary? It's unclear why you need to create a new AzColor
where it's used.

—
Reply to this email directly or view it on GitHub
https://github.com/servo/rust-azure/pull/141/files#r24363008.

[Adenilson]

Yeah, there is a need to make an explicit copy of a immutable AzColor to pass it to C code. I will rename the function to 'copy' as it better describes it use.

[mrobinson]

If you derive from Copy do you really need to implement it as well?

[mrobinson]

Do you need to add Copy since you are simply using clone below?

[mrobinson]

This looks good to me.

[pcwalton]

I'm not a huge fan of the Az prefix leaking everywhere—the Az prefix is for the C binding layer only. Having one color type is of course great though. Could you perhaps reexport the AzColor as Color via pub use AzColor as Color?

[Adenilson]

Agreed. Please check the updated patch.

[Adenilson]

Needs rebase, will close this request and open a new one.