Skip to content
This repository has been archived by the owner. It is now read-only.

Patches for fill and stroke on canvas in servo. #170

Merged
merged 1 commit into from Jun 16, 2015
Merged

Conversation

@hyowon
Copy link
Contributor

hyowon commented Jun 16, 2015

  • Modify fill and stroke functions to handle all pattern types.
  • Add the code to check the zero size gradient.
  • Set ExtendMode::Clamp for SurfacePattern in case of no-repeat.

r? @pcwalton @nox @jdm
cc @yichoi

- Modify fill and stroke functions to handle all pattern types.
- Add the code to check the zero size gradient.
- Set ExtendMode::Clamp for SurfacePattern in case of no-repeat.
@nox nox self-assigned this Jun 16, 2015
@nox
Copy link
Member

nox commented Jun 16, 2015

@metajack
Copy link
Contributor

metajack commented Jun 16, 2015

@bors-servo r=nox

@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2015

📌 Commit 7cebf3b has been approved by nox

@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2015

Testing commit 7cebf3b with merge 4fd0dda...

bors-servo pushed a commit that referenced this pull request Jun 16, 2015
bors-servo
- Modify fill and stroke functions to handle all pattern types.
- Add the code to check the zero size gradient.
- Set ExtendMode::Clamp for SurfacePattern in case of no-repeat.

r? @pcwalton @nox @jdm 
cc @yichoi
@Manishearth
Copy link
Member

Manishearth commented Jun 16, 2015

@bors-servo r- force

@Manishearth Manishearth reopened this Jun 16, 2015
@Manishearth
Copy link
Member

Manishearth commented Jun 16, 2015

@bors-servo r=nox

@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2015

📌 Commit 7cebf3b has been approved by nox

bors-servo pushed a commit that referenced this pull request Jun 16, 2015
bors-servo
- Modify fill and stroke functions to handle all pattern types.
- Add the code to check the zero size gradient.
- Set ExtendMode::Clamp for SurfacePattern in case of no-repeat.

r? @pcwalton @nox @jdm 
cc @yichoi
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2015

Testing commit 7cebf3b with merge 0e86469...

@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2015

☀️ Test successful - travis

@bors-servo bors-servo merged commit 7cebf3b into servo:master Jun 16, 2015
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
homu Testing commit 7cebf3b with merge 0e86469...
Details
bors-servo pushed a commit to servo/servo that referenced this pull request Jun 17, 2015
Fill and stroke for all pattern types and check the zero size gradient.

Depends on servo/rust-azure#170 which has been already merged.
So this patch contains the update of rust-azure.
r? @nox
cc @yichoi

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6402)
<!-- Reviewable:end -->
jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this pull request Jun 12, 2017
…the zero size gradient (from hyowon:canvas_fill_stroke); r=pcwalton

Depends on servo/rust-azure#170 which has been already merged.
So this patch contains the update of rust-azure.
r? @nox
cc @yichoi

Source-Repo: https://github.com/servo/servo
Source-Revision: e1b28d893e54601bf497d0d5b83d77658ca16bac
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Sep 30, 2019
…the zero size gradient (from hyowon:canvas_fill_stroke); r=pcwalton

Depends on servo/rust-azure#170 which has been already merged.
So this patch contains the update of rust-azure.
r? nox
cc yichoi

Source-Repo: https://github.com/servo/servo
Source-Revision: e1b28d893e54601bf497d0d5b83d77658ca16bac

UltraBlame original commit: 5e8571356903e9fe9ff837d9c82134874811bb6e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
…the zero size gradient (from hyowon:canvas_fill_stroke); r=pcwalton

Depends on servo/rust-azure#170 which has been already merged.
So this patch contains the update of rust-azure.
r? nox
cc yichoi

Source-Repo: https://github.com/servo/servo
Source-Revision: e1b28d893e54601bf497d0d5b83d77658ca16bac

UltraBlame original commit: 5e8571356903e9fe9ff837d9c82134874811bb6e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
…the zero size gradient (from hyowon:canvas_fill_stroke); r=pcwalton

Depends on servo/rust-azure#170 which has been already merged.
So this patch contains the update of rust-azure.
r? nox
cc yichoi

Source-Repo: https://github.com/servo/servo
Source-Revision: e1b28d893e54601bf497d0d5b83d77658ca16bac

UltraBlame original commit: 5e8571356903e9fe9ff837d9c82134874811bb6e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.