Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use skia and deps from crates.io #207

Merged
merged 1 commit into from Nov 30, 2015

Conversation

@SimonSapin
Copy link
Member

commented Nov 27, 2015

Fix #206

Review on Reviewable

@SimonSapin SimonSapin force-pushed the crates.io branch from 07daa54 to 53183ec Nov 27, 2015

@metajack

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2015

@bors-servo r+


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2015

📌 Commit 53183ec has been approved by metajack

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2015

⌛️ Testing commit 53183ec with merge 4dca1fd...

bors-servo added a commit that referenced this pull request Nov 27, 2015

Auto merge of #207 - servo:crates.io, r=metajack
Use skia and deps from crates.io

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-azure/207)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2015

💔 Test failed - travis

@jdm

This comment has been minimized.

Copy link
Member

commented Nov 27, 2015

src/azure_hl.rs:486:54: 486:73 error: no method named `as_azure_int_size` found for type `euclid::size::Size2D<i32>` in the current scope

src/azure_hl.rs:486         let mut size = gl_rasterization_context.size.as_azure_int_size();

                                                                         ^~~~~~~~~~~~~~~~~~~

src/azure_hl.rs:486:54: 486:73 help: items from traits can only be used if the trait is implemented and in scope; the following trait defines an item `as_azure_int_size`, perhaps you need to implement it:

src/azure_hl.rs:486:54: 486:73 help: candidate #1: `azure_hl::AsAzureIntSize`

src/azure_hl.rs:486:54: 486:73 error: no method named `as_azure_int_size` found for type `euclid::size::Size2D<i32>` in the current scope

src/azure_hl.rs:486         let mut size = gl_rasterization_context.size.as_azure_int_size();

                                                                         ^~~~~~~~~~~~~~~~~~~

src/azure_hl.rs:486:54: 486:73 help: items from traits can only be used if the trait is implemented and in scope; the following trait defines an item `as_azure_int_size`, perhaps you need to implement it:

src/azure_hl.rs:486:54: 486:73 help: candidate #1: `azure_hl::AsAzureIntSize`

@SimonSapin SimonSapin force-pushed the crates.io branch from 53183ec to 158d807 Nov 30, 2015

@SimonSapin

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2015

@bors-servo r=metajack

Upgraded euclid to use the same version as skia.

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2015

📌 Commit 158d807 has been approved by metajack

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2015

⌛️ Testing commit 158d807 with merge c65fd3d...

bors-servo added a commit that referenced this pull request Nov 30, 2015

Auto merge of #207 - servo:crates.io, r=metajack
Use skia and deps from crates.io

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-azure/207)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2015

☀️ Test successful - travis

@bors-servo bors-servo merged commit 158d807 into master Nov 30, 2015

2 of 4 checks passed

code-review/reviewable Review in progress: 0 of 1 files reviewed, all discussions resolved
Details
homu Testing commit 158d807 with merge c65fd3d...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bors-servo bors-servo referenced this pull request Nov 30, 2015

@SimonSapin SimonSapin deleted the crates.io branch Nov 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.