This repository has been archived by the owner on Jun 8, 2020. It is now read-only.
Derive Debug for (almost) all public types #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving out DrawTarget/DrawTargetBacking, as the latter includes GLRasterizationContext from Skia, which is missing Debug. (And I don't feel like doing this for Skia right now -- this is already quite getting out of hand...)
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Dec 13, 2015
Derive Debug for (almost) all public types Leaving out DrawTarget/DrawTargetBacking, as the latter includes GLRasterizationContext from Skia, which is missing Debug. (And I don't feel like doing this for Skia right now -- this is already quite getting out of hand...) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-azure/212) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
|
@bors-servo r+ |
|
📌 Commit 0a0c2e2 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 14, 2015
Derive Debug for (almost) all public types Leaving out DrawTarget/DrawTargetBacking, as the latter includes GLRasterizationContext from Skia, which is missing Debug. (And I don't feel like doing this for Skia right now -- this is already quite getting out of hand...) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-azure/212) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving out DrawTarget/DrawTargetBacking, as the latter includes
GLRasterizationContext from Skia, which is missing Debug.
(And I don't feel like doing this for Skia right now -- this is already
quite getting out of hand...)