Skip to content
This repository has been archived by the owner. It is now read-only.

Update servo-freetype-sys req to 4.0.1 #234

Closed
wants to merge 2 commits into from
Closed

Update servo-freetype-sys req to 4.0.1 #234

wants to merge 2 commits into from

Conversation

@vvuk
Copy link
Contributor

vvuk commented Aug 4, 2016

... which is servo/libfreetype2#22


This change is Reviewable

@vvuk vvuk force-pushed the vvuk:msvcize branch 2 times, most recently from 7afe2ca to 21a2d99 Aug 7, 2016
@vvuk vvuk force-pushed the vvuk:msvcize branch from 21a2d99 to 02ecde7 Aug 7, 2016
@emilio
Copy link
Member

emilio commented Aug 7, 2016

Can you change the last commit to also include something related with the skia bump? r=me with that.

@bors-servo: try

@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2016

Trying commit 02ecde7 with merge 9275284...

bors-servo added a commit that referenced this pull request Aug 7, 2016
Update servo-freetype-sys req to 4.0.1

... which is servo/libfreetype2#22

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-azure/234)
<!-- Reviewable:end -->
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Aug 7, 2016

Failed: https://travis-ci.org/servo/rust-azure/builds/150473404

Error:

src/azure_hl.rs:490:54: 490:71 error: no method named `as_azure_int_size` found for type `euclid::size::TypedSize2D<i32, euclid::length::UnknownUnit>` in the current scope

src/azure_hl.rs:490         let mut size = gl_rasterization_context.size.as_azure_int_size();

                                                                         ^~~~~~~~~~~~~~~~~

src/azure_hl.rs:490:54: 490:71 help: items from traits can only be used if the trait is implemented and in scope; the following trait defines an item `as_azure_int_size`, perhaps you need to implement it:

src/azure_hl.rs:490:54: 490:71 help: candidate #1: `azure_hl::AsAzureIntSize`

src/azure_hl.rs:490:54: 490:71 error: no method named `as_azure_int_size` found for type `euclid::size::TypedSize2D<i32, euclid::length::UnknownUnit>` in the current scope

src/azure_hl.rs:490         let mut size = gl_rasterization_context.size.as_azure_int_size();

                                                                         ^~~~~~~~~~~~~~~~~

src/azure_hl.rs:490:54: 490:71 help: items from traits can only be used if the trait is implemented and in scope; the following trait defines an item `as_azure_int_size`, perhaps you need to implement it:

src/azure_hl.rs:490:54: 490:71 help: candidate #1: `azure_hl::AsAzureIntSize`

error: aborting due to previous error

Build failed, waiting for other jobs to finish...

error: aborting due to previous error

error: Could not compile `azure`.
@emilio
Copy link
Member

emilio commented Aug 8, 2016

Seems due to euclid's recent update, I'll try to make a PR to fix it today.

bors-servo added a commit that referenced this pull request Aug 8, 2016
Update euclid, freetype-sys, skia.

Also includes the freetype reporting from #234.

r? @larsbergstrom

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-azure/235)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 8, 2016

💥 Test timed out

@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2016

The latest upstream changes (presumably #236) made this pull request unmergeable. Please resolve the merge conflicts.

@nox
Copy link
Member

nox commented Aug 10, 2016

@nox nox closed this Aug 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.