This repository has been archived by the owner on Jun 8, 2020. It is now read-only.
Bump euclid to 0.14 #264
Merged
Bump euclid to 0.14 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This should be in a good state now, r? @jdm |
nox
approved these changes
Jun 8, 2017
src/azure_hl.rs
Outdated
| @@ -1781,6 +1793,13 @@ impl AzPoint { | |||
| y: point.y, | |||
| } | |||
| } | |||
|
|
|||
| fn from_vector_2d(point: &Vector2D<AzFloat>) -> Self { | |||
There was a problem hiding this comment.
Why aren't the from_ methods From impls?
There was a problem hiding this comment.
No idea, I really just followed whatever was already in place (but asked myself the same question), there's also something very similar in the servo repo in the code that interacts with azure (something that should just use From/Into).
src/azure_hl.rs
Outdated
| // Azure does not have a separation between points and vectors, AzPoint is used | ||
| // to represent both | ||
| impl AsAzurePoint for Vector2D<AzFloat> { | ||
| fn as_azure_point(&self) -> AzPoint { |
src/azure_hl.rs
Outdated
| @@ -1781,6 +1793,13 @@ impl AzPoint { | |||
| y: point.y, | |||
| } | |||
| } | |||
|
|
|||
| fn from_vector_2d(point: &Vector2D<AzFloat>) -> Self { | |||
|
@bors-servo delegate+ |
|
✌️ @nical can now approve this pull request |
|
@bors-servo r=nox |
|
📌 Commit cdb257c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 8, 2017
Bump euclid to 0.14 In order for this to build we need servo-skia to be published on crates.io. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-azure/264) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for this to build we need servo-skia to be published on crates.io.
This change is