This repository has been archived by the owner on Jun 8, 2020. It is now read-only.
Cleanup dependencies #281
Merged
Cleanup dependencies #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use features=['serde'] instead
SimonSapin
reviewed
Dec 7, 2017
Cargo.toml
Outdated
| libc = "0.2" | ||
| serde = {version = "1.0", optional = true} | ||
| serde_derive = {version = "1.0", optional = true} | ||
| serde = {version = "1.0", features=["derive"], optional = true} | ||
| servo-skia = "0.30000008" |
There was a problem hiding this comment.
r+ with 0.30000009 here (yet to be published).
There was a problem hiding this comment.
Well it's not bumping euclid either. I can include it in this PR if you want to
There was a problem hiding this comment.
Oh right, sorry. Renaming the feature is a breaking change and the skia update is close, so maybe let’s land everything together?
|
@bors-servo r+ Thanks! |
|
📌 Commit de0b8cd has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 7, 2017
Cleanup dependencies <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-azure/281) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is