This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport StrokeStyle #49
Merged
Conversation
|
As @sanxiyn commented , I fixed it. I set the bits as same as StrokeOptions initial values in |
|
Looks good other than the magic number. |
|
Addressed a comment. |
|
Yes, please squash and I'll r+ and merge. |
|
Thanks, I squashed them. |
This comment has been minimized.
This comment has been minimized.
metajack
commented on e921722
Aug 27, 2013
|
r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sammykim commentedAug 26, 2013
I modified some codes in azure to support StrokeStyle like cap-style, join-style and some others. But there are some problems.
First of them, It doesn't look the join-style works well. I tested it join-style bits beside cap-style in C. It looks 21(cap,join) as hex in C. So as you can see in code, I implemented set method in azure_hl. I think the bit is set properly but the only join_style isn't applied that I want.(I tested CAP_BUTT and CAP_ROUND. Both of them work fine. )
Second, I will send PR about border-style after this is merged. I can render DashedBorderStyle but can't render DottedBorderStyle as I expect. Because I supposed servo and firefox uses same graphic engine. So I refered to firefox code(link : http://mxr.mozilla.org/mozilla-central/source/layout/base/nsCSSRenderingBorders.cpp#1080) to render them properly specially for DashPattern and cap, join style.
If you can catch what thoes problem are, let me know that I will fix it before it's merged. But I think second one is you might catch after I send main codes for border-style.