Skip to content

/ rust-css

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl cm postfix #28

Merged
merged 2 commits into from Aug 19, 2013
Merged

Impl cm postfix #28

merged 2 commits into from Aug 19, 2013

Conversation

@recrack
Copy link
Contributor

recrack commented Aug 13, 2013

Related to servo/servo#723
@recrack recrack mentioned this pull request Aug 13, 2013
Merged
@metajack
Copy link
Contributor

metajack commented Aug 13, 2013

It's my understanding that the ComputedStyle gets normalized in netsurf to one of: absolute value in px (or pt) or percentage value. I'm not sure why it has both px and pt. It would be better if it had only one of them.

I understand we need to intake cm values, but shouldnt' they get normalized internally?

@SimonSapin care to weigh in?
@SimonSapin
Copy link
Member

SimonSapin commented Aug 13, 2013

@metajack Yes all CSS absolute length units should be converted to one as soon as parsing (maybe modulo CSSOM, but we can figure that out later.) See my comments on the related PR: servo/servo#723 (comment)
@recrack
Copy link
Contributor Author

recrack commented Aug 14, 2013

@SimonSapin Is it ok?
@SimonSapin
Copy link
Member

SimonSapin commented Aug 14, 2013

Yes, this does look better.
@metajack
Copy link
Contributor

metajack commented Aug 14, 2013

r+, but this needs a rebase since the fixed test case got merged first.
recrack added 2 commits Aug 12, 2013
@recrack
Update CSSUnit(Pt, Cm, Mm, In, Pc)
7a06393
@recrack
Update testcase
f3d5370
@recrack
Copy link
Contributor Author

recrack commented Aug 19, 2013

r? @metajack
@metajack

This comment has been minimized.

Sign in to view
Copy link

metajack commented on f3d5370 Aug 19, 2013

r+
metajack added a commit that referenced this pull request Aug 19, 2013
@metajack
Merge pull request #28 from recrack/length_postfix
f02576d 
Impl cm postfix
@metajack metajack merged commit f02576d into servo:master Aug 19, 2013
kmcallister pushed a commit to kmcallister/servo that referenced this pull request Oct 30, 2013
bors-servo
auto merge of servo#723 : recrack/servo/add_cm, r=metajack
488972e 
Related to servo/rust-css#28
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Sep 30, 2019
@marco-c
servo: Merge #723 - Impl cm postfix (from recrack:add_cm); r=metajack
696c092 
Related to servo/rust-css#28

Source-Repo: https://github.com/servo/servo
Source-Revision: 488972e817a072f23b36e92b02a3cb5cccffa90e

UltraBlame original commit: 61016c08b892df48f82bfa75413704c59a15b29d
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Sep 30, 2019
@marco-c
servo: Merge #723 - Impl cm postfix (from recrack:add_cm); r=metajack
961aaf1 
Related to servo/rust-css#28

Source-Repo: https://github.com/servo/servo
Source-Revision: 488972e817a072f23b36e92b02a3cb5cccffa90e

UltraBlame original commit: 61016c08b892df48f82bfa75413704c59a15b29d
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
@marco-c
servo: Merge #723 - Impl cm postfix (from recrack:add_cm); r=metajack
af2e152 
Related to servo/rust-css#28

Source-Repo: https://github.com/servo/servo
Source-Revision: 488972e817a072f23b36e92b02a3cb5cccffa90e

UltraBlame original commit: 61016c08b892df48f82bfa75413704c59a15b29d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@recrack @metajack @SimonSapin
You can’t perform that action at this time.