Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test serde-serialization feature on Travis CI. #103

Closed
wants to merge 1 commit into from
Closed

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Mar 16, 2016

This change is Reviewable

@frewsxcv frewsxcv force-pushed the serde-travis branch 2 times, most recently from 63c52c6 to a5475be Mar 16, 2016
@SimonSapin
Copy link
Member

SimonSapin commented Mar 16, 2016

I don’t remember if cssparser has had this before, but it was deliberate to either remove it or not add it.

Serde’s dependencies are often broken by libsyntax changes which would cause Travis to fail in this repository for something that can’t be fixed in this repository. On the other hand, the only code in this repository is #[derive] so it’s very hard to have a bug there. This PR would almost never help us catch real bugs in this repository.

@frewsxcv
Copy link
Member Author

frewsxcv commented Mar 17, 2016

Fair enough!

@frewsxcv frewsxcv closed this Mar 17, 2016
@frewsxcv frewsxcv deleted the serde-travis branch Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.