Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upNew characters escaped in serialize_name #104
Merged
Conversation
|
The code looks correct, but could you add some unit tests please? |
|
OK I'll add, forgot about it. |
|
Please add unit tests in #[test]
fn identifier_serialization() {
assert_eq!(Token::Ident("\0").to_css_string(), "\u{FFFD}");
assert_eq!(Token::Ident("a\0").to_css_string(), "a\u{FFFD}");
// ...
}with one |
Added escape of NULL (U+0000) char and escape for characters in the range [\1-\1f] (U+0001 to U+001F) or U+007F according to https://drafts.csswg.org/cssom/#serialize-an-identifier Needed for proper CSS tests servo/servo#10685
|
I've added tests. |
|
Great, thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 6, 2016
New characters escaped in serialize_name Added escape of NULL (U+0000) char and escape for characters in the range [\1-\1f] (U+0001 to U+001F) or U+007F according to https://drafts.csswg.org/cssom/#serialize-an-identifier Needed for proper CSS tests servo/servo#10685 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/104) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mskrzypkows commentedMay 4, 2016
•
edited by larsbergstrom
Added escape of NULL (U+0000) char and escape for characters
in the range [\1-\1f](U+0001 to U+001F) or U+007F
according to https://drafts.csswg.org/cssom/#serialize-an-identifier
Needed for proper CSS tests servo/servo#10685
This change is