Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow serde 0.8 and remove use of compiler plugins #106

Merged
merged 5 commits into from Aug 3, 2016
Merged

Conversation

@nox
Copy link
Member

nox commented Jul 30, 2016

This change is Reviewable

@nox nox mentioned this pull request Jul 30, 2016
23 of 23 tasks complete
@SimonSapin
Copy link
Member

SimonSapin commented Aug 3, 2016

@bors-servo r+


Reviewed 1 of 1 files at r1, 5 of 5 files at r2, 3 of 3 files at r3, 1 of 1 files at r4, 1 of 1 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bors-servo
Copy link
Contributor

bors-servo commented Aug 3, 2016

📌 Commit 7cf8e82 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Aug 3, 2016

Testing commit 7cf8e82 with merge e98fc6b...

bors-servo added a commit that referenced this pull request Aug 3, 2016
Allow serde 0.8 and remove use of compiler plugins

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/106)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 3, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 7cf8e82 into servo:master Aug 3, 2016
3 checks passed
3 checks passed
code-review/reviewable 5 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:serde branch Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.