Skip to content

Inline more parser methods. #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 27, 2017
Merged

Inline more parser methods. #183

merged 3 commits into from
Aug 27, 2017

Conversation

@jdm
Copy link
Member

@jdm jdm commented Aug 23, 2017 •
edited by larsbergstrom
Loading

These showed up in some perf profiles as non-inlined parts of inlined parser methods.

This change is Reviewable

@jdm jdm changed the title Inline Delimiters methods. Inline more parser methods. Aug 23, 2017
@jdm
Copy link
Member Author

jdm commented Aug 27, 2017

Ping @SimonSapin.

@SimonSapin
Copy link
Member

SimonSapin commented Aug 27, 2017

Looks good. Gecko before:

  38.208 ±  0.419 ms    Stylo.Servo_StyleSheet_FromUTF8Bytes_Bench
  29.476 ±  0.028 ms    Stylo.Gecko_nsCSSParser_ParseSheet_Bench
 309.244 ±  0.266 ms    Stylo.Servo_DeclarationBlock_SetPropertyById_Bench
 310.305 ±  0.213 ms    Stylo.Servo_DeclarationBlock_SetPropertyById_WithInitialSpace_Bench

After:

  37.789 ±  0.431 ms    Stylo.Servo_StyleSheet_FromUTF8Bytes_Bench
  29.517 ±  0.033 ms    Stylo.Gecko_nsCSSParser_ParseSheet_Bench
 288.813 ±  7.443 ms    Stylo.Servo_DeclarationBlock_SetPropertyById_Bench
 289.749 ±  0.004 ms    Stylo.Servo_DeclarationBlock_SetPropertyById_WithInitialSpace_Bench

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Aug 27, 2017

📌 Commit 9ce7287 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Aug 27, 2017

⌛ Testing commit 9ce7287 with merge cf3d20d...

bors-servo pushed a commit that referenced this pull request Aug 27, 2017
Auto merge of #183 - servo:jdm-patch-1, r=SimonSapin
cf3d20d 
Inline more parser methods.

These showed up in some perf profiles as non-inlined parts of inlined parser methods.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/183)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 27, 2017

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing cf3d20d to master...

@bors-servo bors-servo merged commit 9ce7287 into master Aug 27, 2017
@SimonSapin SimonSapin deleted the jdm-patch-1 branch August 27, 2017 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jdm @SimonSapin @bors-servo