Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove Column token. #203
Merged
Remove Column token. #203
Conversation
It no longer exists in the css-syntax spec.
|
r? @SimonSapin |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 20, 2017
Remove Column token. It no longer exists in the css-syntax spec. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/203) <!-- Reviewable:end -->
|
|
|
This is a breaking API change, please make sure you increment the version number accordingly before publishing on crates.io. (Ideally that would have been part of the PR.) |
bors-servo
added a commit
that referenced
this pull request
Nov 20, 2017
Breaking version bump to account for #203. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/204) <!-- Reviewable:end -->
|
Thanks, I'll try to remember about version bumps next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
heycam commentedNov 20, 2017
•
edited by larsbergstrom
It no longer exists in the css-syntax spec.
This change is