Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upClean up a bit now that lifetimes are non-lexical. #269
Conversation
|
Nice! |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 25, 2019
Clean up a bit now that lifetimes are non-lexical. I was doing some performance work and some of these clone() calls appear in profiles. There's more to do but I'd rather take out the low hanging fruit first :)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedNov 25, 2019
I was doing some performance work and some of these clone() calls appear in
profiles. There's more to do but I'd rather take out the low hanging fruit first
:)