Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse Result/Err(()) instead of Option/None to indicate a parse error. #57
Conversation
color.rs
Outdated
| @@ -33,20 +33,20 @@ pub enum Color { | |||
|
|
|||
| // Return None on invalid/unsupported value (not a color) | |||
This comment has been minimized.
This comment has been minimized.
nth.rs
Outdated
| @@ -10,12 +10,12 @@ use ast::*; | |||
| /// Parse the An+B notation, as found in the ``:nth-child()`` selector. | |||
| /// The input is typically the arguments of a function component value. | |||
| /// Return Some((A, B)), or None for a syntax error. | |||
This comment has been minimized.
This comment has been minimized.
tokenizer.rs
Outdated
| Some(value) => String(value), | ||
| None => BadString | ||
| Ok(value) => String(value), | ||
| Err(()) => BadString | ||
| } | ||
| } | ||
|
|
||
|
|
||
| // Return None on syntax error (ie. unescaped newline) |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedAug 11, 2014
r? @metajack