Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExport `parse_color_keyword` for use in legacy HTML color parsing. #65
Conversation
|
I think that if you make this PR’s parent commit be the one Servo currently uses, you will be able to use it as-is in Servo. And if you add the r+ with these two changes. |
|
This is so we don’t need a branch that we’d have to maintain as long as we want |
I could have gotten around the privacy restriction by synthesizing a fake CSS AST and parsing that, but that would have been less efficient.
pcwalton
added a commit
that referenced
this pull request
Dec 8, 2014
Export `parse_color_keyword` for use in legacy HTML color parsing.
pcwalton
merged commit 97d8c3b
into
servo:master
1 check was pending
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedDec 8, 2014
I could have gotten around the privacy restriction by synthesizing a
fake CSS AST and parsing that, but that would have been less efficient.
This won't merge because it's incompatible with the enum changes; I'll have to create a separate branch once the review is done.
r? @SimonSapin