Skip to content

/ rust-cssparser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize the ToCss trait and implement it on more things. #67

Merged
merged 9 commits into from Dec 29, 2014
Merged

Modernize the ToCss trait and implement it on more things. #67

merged 9 commits into from Dec 29, 2014
+377 −202

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Dec 21, 2014

It is now based on the TextWriter trait: https://github.com/SimonSapin/rust-std-candidates#the-textwriter-trait

It should be used for CSS serialization instead of Show.
SimonSapin added 8 commits Dec 20, 2014
@SimonSapin
Merge commit 3f98f13 'Export `parse_color_keyword`' into to_css
3f49976
@SimonSapin
Refactor ToCss to use TextWriter.
4ccdf6d 
https://github.com/SimonSapin/rust-std-candidates#the-textwriter-trait
@SimonSapin
Implement ToCss for more AST things.
Loading status checks…
6f43977
@SimonSapin
Implement ToCss for Color and RGBA
Loading status checks…
ff2a0b4
@SimonSapin
Add ToCss::fmt_to_css, a convenience method for implementing Show.
6c4d550
@SimonSapin
Implement ToCss for declaration lists
Loading status checks…
d6f2908
@SimonSapin
Add CssStringWriter
Loading status checks…
a2b0b6b
@SimonSapin
Merge branch 'to_css'
Loading status checks…
aa273f4 
Conflicts:
	Cargo.toml
	src/color.rs
	src/serializer.rs
@SimonSapin SimonSapin mentioned this pull request Dec 21, 2014
Merged
@SimonSapin
Copy link
Member Author

SimonSapin commented Dec 21, 2014

The branch starts from an older commit that compiles with Servo’s version of Rust. servo/servo#4455 updates to just before the merge commit.

r? @jdm
@SimonSapin
Upgrade to rustc 0.13.0-nightly (99d6956c3 2014-12-18 20:32:07 +0000)
Loading status checks…
d405f03
@jdm
Copy link
Member

jdm commented Dec 29, 2014

I read the end result, and it makes sense to me. Do we care about newlines or spaces between declarations or anything like that?
@SimonSapin
Copy link
Member Author

SimonSapin commented Dec 29, 2014

Do we care about newlines or spaces between declarations or anything like that?

Not really. I’ve implemented ToCss on ast::Declaration and the like because I could, but they’re only intermediate values in parsing, not what we keep around in Servo. And they’re going away in my in-progress rewrite: https://github.com/servo/rust-cssparser/tree/incremental
@jdm
Copy link
Member

jdm commented Dec 29, 2014

Ok, feel free to merge this whenever you'd like.
@SimonSapin
Copy link
Member Author

SimonSapin commented Dec 29, 2014

I’ll do so when servo/servo#4455 is ready to be merged as well.
SimonSapin added a commit that referenced this pull request Dec 29, 2014
@SimonSapin
Merge pull request #67 from servo/to_css-merged
Loading status checks…
759d0d9 
Modernize the ToCss trait and implement it on more things.
@SimonSapin SimonSapin merged commit 759d0d9 into master Dec 29, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@SimonSapin SimonSapin deleted the to_css-merged branch Dec 29, 2014
bors-servo pushed a commit to servo/servo that referenced this pull request Dec 29, 2014
bors-servo
auto merge of #4455 : servo/servo/to_css, r=jdm
Loading status checks…
8a7edb7 
See servo/rust-cssparser#67 and #4440.

r? @jdm
bors-servo pushed a commit to servo/servo that referenced this pull request Dec 29, 2014
bors-servo
auto merge of #4455 : servo/servo/to_css, r=jdm
Loading status checks…
e6b1fc6 
See servo/rust-cssparser#67 and #4440.

r? @jdm
bors-servo pushed a commit to servo/servo that referenced this pull request Dec 29, 2014
bors-servo
auto merge of #4455 : servo/servo/to_css, r=jdm
Loading status checks…
b3059ee 
See servo/rust-cssparser#67 and #4440.

r? @jdm
jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this pull request Jun 12, 2017
@SimonSapin
servo: Merge #4455 - Start using the ToCss trait, to be used for CSS …
9ba3433 
…serialization (from servo:to_css); r=jdm

See servo/rust-cssparser#67 and servo/servo#4440.

r? @jdm

Source-Repo: https://github.com/servo/servo
Source-Revision: b3059ee85b71b067e4b9e337faef53ae4a96c66d
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Sep 30, 2019
@marco-c
servo: Merge #4455 - Start using the ToCss trait, to be used for CSS …
66a722c 
…serialization (from servo:to_css); r=jdm

See servo/rust-cssparser#67 and servo/servo#4440.

r? jdm

Source-Repo: https://github.com/servo/servo
Source-Revision: b3059ee85b71b067e4b9e337faef53ae4a96c66d

UltraBlame original commit: 445d2613a14ce5e1b73ec572f59caa6683742838
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
@marco-c
servo: Merge #4455 - Start using the ToCss trait, to be used for CSS …
af15046 
…serialization (from servo:to_css); r=jdm

See servo/rust-cssparser#67 and servo/servo#4440.

r? jdm

Source-Repo: https://github.com/servo/servo
Source-Revision: b3059ee85b71b067e4b9e337faef53ae4a96c66d

UltraBlame original commit: 445d2613a14ce5e1b73ec572f59caa6683742838
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
@marco-c
servo: Merge #4455 - Start using the ToCss trait, to be used for CSS …
d3fed14 
…serialization (from servo:to_css); r=jdm

See servo/rust-cssparser#67 and servo/servo#4440.

r? jdm

Source-Repo: https://github.com/servo/servo
Source-Revision: b3059ee85b71b067e4b9e337faef53ae4a96c66d

UltraBlame original commit: 445d2613a14ce5e1b73ec572f59caa6683742838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@SimonSapin @jdm
You can’t perform that action at this time.