Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upClamp to MAX / INFINITY rather than panic on overflow in number parsing #73
+155
−60
Conversation
This comment has been minimized.
This comment has been minimized.
|
This comment is confusing. |
This comment has been minimized.
This comment has been minimized.
|
The change made it wrong, and I forgot to update it. Fixed in a follow-up commit. |
This comment has been minimized.
This comment has been minimized.
|
} else { |
This comment has been minimized.
This comment has been minimized.
|
Done |
|
I haven't looked at the merge commit; the rest look fine to me. Should I be looking at the merge? |
|
The merge includes some fairly simple conflict resolutions, as well as a replacement of By the way, the commit to use in Servo (unless Servo does another Rust upgrade) is the one before the merge. |
|
I don't think there's a burning need to adopt these changes before the next upgrade. Looks good to me! |
I’ll take that as r+ :) |
SimonSapin
added a commit
that referenced
this pull request
Apr 2, 2015
Clamp to MAX / INFINITY rather than panic on overflow in number parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedApr 2, 2015
r? @jdm
This also changes the numeric types in tokens from
f64/i64tof32/i32, which might requires some changes in Servo.