Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake `Tokenizer` public #74
Conversation
|
Why? What's missing in (In general, when requesting a change, it's helpful to explain the motivation in the request.) |
|
|
|
It’s not necessarily unacceptable but it should be justified and this doesn’t seem like a strong enough justification. The intended usage is that when https://github.com/servo/rust-cssparser/blob/72cf5e4ea8/src/rules_and_declarations.rs#L389 This takes care of block nesting (and spec-compliant error recovery) for you. When using the tokenizer directly, you’d have to keep track yourself of a stack of opened blocks to find the matching closing token. I’d consider making the tokenizer public if there is a use case for opting out completely of this block nesting handling. |
|
@xojoc, does my comment above help? |
|
Yes, thank you :) I just needed to get more familiar with Rust. |
xojoc commentedMay 24, 2015