Skip to content

/ rust-cssparser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clamp rgb values to [0,1] #83

Merged
merged 1 commit into from Aug 4, 2015
Merged

clamp rgb values to [0,1] #83

merged 1 commit into from Aug 4, 2015
+16 −11

Conversation

@dzbarsky
Copy link
Member

dzbarsky commented Aug 4, 2015

Fixes #76

Review on Reviewable
@metajack
Copy link
Contributor

metajack commented Aug 4, 2015

r? @SimonSapin
@dzbarsky dzbarsky force-pushed the dzbarsky:clamp branch from 9a8620d to 3233bbb Aug 4, 2015
@dzbarsky
clamp rgb values to [0,1]
Loading status checks…
3233bbb
@dzbarsky
Copy link
Member Author

dzbarsky commented Aug 4, 2015

Here's what Gecko does: http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSParser.cpp#6441
@SimonSapin
Copy link
Member

SimonSapin commented Aug 4, 2015

I’ve written in #76 (comment) why R G and B channels are currently not clamped. My understanding of the spec is that they shouldn’t. I see that Gecko does it, but why?
@SimonSapin SimonSapin mentioned this pull request Aug 4, 2015
Merged
bors-servo pushed a commit that referenced this pull request Aug 4, 2015
bors-servo
Auto merge of #84 - servo:clamp_, r=SimonSapin
Loading status checks…
fd45d73 
Clamp rgb values to [0,1]

#83 plus a code comment linking to discussion.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/84)
<!-- Reviewable:end -->
@bors-servo bors-servo merged commit 3233bbb into servo:master Aug 4, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dzbarsky dzbarsky deleted the dzbarsky:clamp branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@dzbarsky @metajack @SimonSapin @bors-servo
You can’t perform that action at this time.